Skip to content

fix: re-sign macOS binaries after stripping in copy_cross.sh#21893

Merged
ludamad merged 1 commit intomerge-train/barretenbergfrom
claudebox/ff6f44025bbcff9e-2
Mar 23, 2026
Merged

fix: re-sign macOS binaries after stripping in copy_cross.sh#21893
ludamad merged 1 commit intomerge-train/barretenbergfrom
claudebox/ff6f44025bbcff9e-2

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Mar 23, 2026 •
edited by ludamad
Loading

Summary

copy_cross.sh runs llvm-strip-20 on all cross-compiled binaries (including macOS) after they were already code-signed by inject_version in bootstrap.sh. Stripping modifies the binary content, which invalidates the ad-hoc code signature applied by ldid -S.

This adds a re-signing step with ldid -S for macOS Mach-O binaries after stripping, matching the pattern already used in inject_version.

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 23, 2026
@ludamad ludamad marked this pull request as ready for review March 23, 2026 13:15
@ludamad ludamad merged commit 14cf5b0 into merge-train/barretenberg Mar 23, 2026
30 of 34 checks passed
@ludamad ludamad deleted the claudebox/ff6f44025bbcff9e-2 branch March 23, 2026 13:15
@AztecBot AztecBot mentioned this pull request Mar 23, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2026
@ludamad
feat: merge-train/barretenberg (#21882)
7ac4a3c 
BEGIN_COMMIT_OVERRIDE
feat: add many_from_buffer_exact for strict buffer size validation
(#21880)
chore!: Make `is_less_than` range-check stricter (#21723)
fix: re-sign macOS binaries after stripping in copy_cross.sh (#21893)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludamad ludamad ludamad approved these changes

Assignees

No one assigned

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AztecBot @ludamad